Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #3632
Intended Change
This PR suppresses logging messages from non-failing test cases.
It is done in the following way:
Using the JUnit Extensions interface that triggers methods before and after test execution.
Before test execution: Install a
StringListAppenderin the root logger, which captures all logging messages in a list of strings. Save the old console appender.After test execution: If an exception was thrown (e.g.,
AssertionException), print all captured messages to the console. Clean the list in any case afterwards. Re-establish the old console appender.Install these lifecycle methods globally using (a)
junit.propertiesand (b) theServiceLoaderinterface. SeePlan
assert fail;) after review. (Testing purpose)key.util-testfor sharing the test utilities.)testImplementation project(":key.core").sourceSets.test.outputinkey.core.symbex/build.gradle.Type of pull request
Ensuring quality