Add reachable Java state properties to invariant for modified local variables (fixes #3728)#3747
Conversation
unp1
force-pushed
the
fix3728
branch
4 times, most recently
from
3f2005a to
5bee329
Compare
wadoon
approved these changes
Feb 18, 2026
| @@ -72,8 +72,7 @@ public MatchResultInfo check(SchemaVariable var, SyntaxElement instCandidate, | |||
| .map(methodFrame -> MiscTools.getSelfTerm(methodFrame, services)).orElse(null); | |||
|
|
|||
| // TODO: Handle exception?! | |||
| 5138, 4127, true, true, true); | ||
| var iteration2 = | ||
| sliceProofFullFilename(iteration1.second, 4236, 4229, true, true, true); | ||
| sliceProofFullFilename(iteration1.second, 4127, 4125, true, true, true); |
Member
There was a problem hiding this comment.
These are very overspecific assertions.
I also stumble often over them. @FliegendeWurst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds reachable state properties for modified local variables to loop invariant
Related Issue
This pull request resolves #3728.
Intended Change
Information about a modified reference-typed variable to be null or created or to be within its integral range (for primitive values) are added to the invariant.
Type of pull request
Ensuring quality
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.