feat: Add support for nullable reference types in generator#368
Merged
Conversation
Previously, the source generator would not correctly identify types declared with nullable reference types (e.g., `Brush?`, `DependencyObject?`). This prevented the generation of expected helper extension methods for properties of these types. This change updates the generator to recognize both nullable and non-nullable versions of relevant types, ensuring comprehensive helper generation. A new compilation-only test validates this functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the source generator would not correctly identify types declared with nullable reference types (e.g.,
Brush?,DependencyObject?). This prevented the generation of expected helper extension methods for properties of these types.This change updates the generator to recognize both nullable and non-nullable versions of relevant types, ensuring comprehensive helper generation. A new compilation-only test validates this functionality.