KC-1470: Protect Integration config records from Service Mode API access - #2383
Merged
amangalampalli-ks merged 7 commits intoSep 21, 2026
Conversation
amangalampalli-ks
marked this pull request as ready for review
September 21, 2026 07:55
pvagare-ks
approved these changes
Sep 21, 2026
sali-ks
approved these changes
Sep 21, 2026
amangalampalli-ks
merged commit Sep 21, 2026
e8aa737
into
add/protect-integration-config-records
4 checks passed
craiglurey
pushed a commit
that referenced
this pull request
Sep 21, 2026
…ess (#2383) (#2385) * Protect Integration config records from Service Mode API access * Add terraform backward compatability and test cases * Fix review comments * Fix failing test case in windows * Restrict folder access via Service Mode for all *-setup commands * Prevent config and service config json file attachments * Fix claude review comments
amangalampalli-ks
deleted the
add/protect-integration-config-records-int
branch
September 22, 2026 09:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blocks Service Mode API access to the Slack, Teams, Google Chat, and Terraform integration config records, matching the protection Commander's own config record already has.
Changes
--sync-downstill works, but only for its own record, never a different integration's--sync-downcarve-out is a separate follow-up ticketNote: Terraform's env var was renamed (
KEEPER_TERRAFORM→TERRAFORM_RECORD); the old name is still recognized as a fallback, so already-deployed containers keep working without an immediate re-run ofterraform-app-setupbut laterKEEPER_TERRAFORMwill be removed to apply this restriction.