Skip to content

KC-1470: Protect Integration config records from Service Mode API access - #2383

Merged
amangalampalli-ks merged 7 commits into
add/protect-integration-config-recordsfrom
add/protect-integration-config-records-int
Sep 21, 2026
Merged

amangalampalli-ks merged 7 commits into
add/protect-integration-config-recordsfrom
add/protect-integration-config-records-int

Conversation

@amangalampalli-ks

@amangalampalli-ks amangalampalli-ks commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Blocks Service Mode API access to the Slack, Teams, Google Chat, and Terraform integration config records, matching the protection Commander's own config record already has.

Changes

  • Records are blocked by both UID and title, so renaming a record can't bypass it
  • Slack and Google Chat's --sync-down still works, but only for its own record, never a different integration's
  • Teams' record is protected too; its own --sync-down carve-out is a separate follow-up ticket
  • A misconfigured pinning env var now falls back to title matching instead of becoming a phantom protected token

Note: Terraform's env var was renamed (KEEPER_TERRAFORM → TERRAFORM_RECORD); the old name is still recognized as a fallback, so already-deployed containers keep working without an immediate re-run of terraform-app-setup but later KEEPER_TERRAFORM will be removed to apply this restriction.

@amangalampalli-ks amangalampalli-ks self-assigned this Sep 21, 2026
@amangalampalli-ks
amangalampalli-ks marked this pull request as ready for review September 21, 2026 07:55
@amangalampalli-ks
amangalampalli-ks merged commit e8aa737 into add/protect-integration-config-records Sep 21, 2026
4 checks passed
craiglurey pushed a commit that referenced this pull request Sep 21, 2026
…ess (#2383) (#2385)

* Protect Integration config records from Service Mode API access

* Add terraform backward compatability and test cases

* Fix review comments

* Fix failing test case in windows

* Restrict folder access via Service Mode for all *-setup commands

* Prevent config and service config json file attachments

* Fix claude review comments
@amangalampalli-ks
amangalampalli-ks deleted the add/protect-integration-config-records-int branch September 22, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants