Skip to content

KC-1470: Protect Integration config records and folders from Service Mode API access - #2385

Merged
craiglurey merged 1 commit into
releasefrom
add/protect-integration-config-records
Sep 21, 2026
Merged

craiglurey merged 1 commit into
releasefrom
add/protect-integration-config-records

Conversation

@amangalampalli-ks

@amangalampalli-ks amangalampalli-ks commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Blocks Service Mode API access to the Slack, Teams, Google Chat, and Terraform integration config records and folders, matching the protection Commander's own config record already has.

Changes

  • Records, Folders and all config.json and service_config.json attachments are blocked by both UID and title, so renaming can't bypass it
  • Slack and Google Chat's --sync-down still works, but only for its own record, never a different integration's

Note: Terraform's env var was renamed (KEEPER_TERRAFORM → TERRAFORM_RECORD); the old name is still recognized as a fallback, so already-deployed containers keep working for now but later will require to re setup as KEEPER_TERRAFORM will be removed to apply this restriction.

…ess (#2383)

* Protect Integration config records from Service Mode API access

* Add terraform backward compatability and test cases

* Fix review comments

* Fix failing test case in windows

* Restrict folder access via Service Mode for all *-setup commands

* Prevent config and service config json file attachments

* Fix claude review comments
@amangalampalli-ks amangalampalli-ks self-assigned this Sep 21, 2026
@amangalampalli-ks amangalampalli-ks changed the title KC-1470: Protect Integration config records from Service Mode API access KC-1470: Protect Integration config records and folders from Service Mode API access Sep 21, 2026
@amangalampalli-ks
amangalampalli-ks marked this pull request as ready for review September 21, 2026 14:23
@craiglurey
craiglurey merged commit 1a2ef26 into release Sep 21, 2026
4 checks passed
@sk-keeper
sk-keeper deleted the add/protect-integration-config-records branch September 21, 2026 15:54
sk-keeper pushed a commit that referenced this pull request Sep 26, 2026
…ess (#2383) (#2385)

* Protect Integration config records from Service Mode API access

* Add terraform backward compatability and test cases

* Fix review comments

* Fix failing test case in windows

* Restrict folder access via Service Mode for all *-setup commands

* Prevent config and service config json file attachments

* Fix claude review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants