KC-1471: Prevent newline injection in connect command prompts - #2390
Open
sshrushanth-ks wants to merge 2 commits into
Open
sshrushanth-ks wants to merge 2 commits into
sshrushanth-ks wants to merge 2 commits into
Conversation
Escape control chars and handle comments to prevent hidden commands from bypassing the confirmation prompt. Attackers with Can Edit on shared records could exfiltrate device credentials without operator visibility.
sshrushanth-ks
marked this pull request as ready for review
September 23, 2026 08:46
sshrushanth-ks
requested review from
adeshmukh-ks,
amangalampalli-ks and
pvagare-ks
September 23, 2026 08:46
adeshmukh-ks
approved these changes
Sep 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escape control characters instead of deleting them, and properly handle shell comments to expose multi-statement payloads in the confirmation prompt. Attackers with Can Edit on shared records could inject commands that execute silently, exfiltrating device credentials without operator visibility.
Changes
keepercommander/commands/connect_prompts.py:unit-tests/test_connect_security.py: