Conversation
The ADD_IDENTITY handler called EllipticCurvePublicNumbers.from_encoded_point(), which cryptography removed in 39.0.0, and built the ECDSA public key blob without the RFC 5656 curve-name string. Use EllipticCurvePublicKey.from_encoded_point() and include the curve name so ssh-add and SSH clients accept the key. After implementing the changes, i tested the full process using an ECDSA key and confirmed the change resolved the issue.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Commander's built-in SSH agent (
ssh-agent startthenssh <record>) fails to add anyecdsa-sha2-*key:Two issues in the ECDSA branch of the
ADD_IDENTITYhandler inkeepercommander/commands/ssh_agent.py:EllipticCurvePublicNumbers.from_encoded_point()was removed in cryptography 39.0.0;requirements.txtrequires>=46.0.6, so this raises on every supported install.ssh-add -lreportselliptic curve does not matchand authentication fails.Fix
EllipticCurvePublicKey.from_encoded_point(curve, point).public_numbers().curve_nameinkey.key_blob.No dependency change; the replacement API exists in every cryptography version Commander has ever required.
Testing
unit-tests/suite passes.