KC-1462: Validate record ownership in audit-log command - #2395
Draft
sshrushanth-ks wants to merge 1 commit into
Draft
sshrushanth-ks wants to merge 1 commit into
sshrushanth-ks wants to merge 1 commit into
Conversation
* Validate record ownership in audit-log command Prevent shared records from being used as audit-log export destination. Only operator-owned records are now eligible, preventing attackers from hijacking the export by sharing a malicious record with matching title. * Harden audit-log ownership check with meta_data_cache fallback and tests Add helper function with fallback to meta_data_cache. Remove TLS verification bypass from Splunk exports. Add 4 test cases covering ownership validation, fallback behavior, and safe defaults.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent shared records from being used as audit-log export destination. Only operator-owned records are now eligible, preventing attackers from hijacking the export by sharing a malicious record with matching title.
Changes
keepercommander/commands/aram.py:unit-tests/test_command_enterprise.py:test_audit_log_ownership_skips_non_owned_record()to verify owned record is selected when both shared and owned records exist with matching titletest_audit_log_ownership_returns_none_when_only_shared()to verify shared record is rejected when it's the only matchtest_audit_log_ownership_uses_meta_data_cache_fallback()to verify fallback to meta_data_cache works when record_owner_cache is missingtest_audit_log_ownership_fails_closed_on_unknown()to verify unknown ownership is treated as safe default