Skip to content

KC-1478: Fix false 'Supported columns' warning in enterprise-info when requesting base fields - #2397

Merged
craiglurey merged 1 commit into
releasefrom
enterprise-info-column-definition-fix
Sep 24, 2026
Merged

craiglurey merged 1 commit into
releasefrom
enterprise-info-column-definition-fix

Conversation

@sshrushanth-ks

Copy link
Copy Markdown
Contributor

Summary

Fix enterprise-info --columns printing a false "Supported X columns" warning when the requested columns include a field that's always present in the output (user_id/email for users, team_uid/name for teams, node_id/name for nodes, role_id/name for roles) but isn't in the optional SUPPORTED_*_COLUMNS validation list. The command already succeeded and returned the field correctly — only the warning was wrong.

Changes

  • keepercommander/commands/enterprise.py:
    • Add BASE_NODE_COLUMNS, BASE_USER_COLUMNS, BASE_TEAM_COLUMNS, BASE_ROLE_COLUMNS sets identifying the fields always included in each row regardless of --columns
    • Exclude the relevant base-columns set from the unsupported-column check for nodes, users, teams, and roles, so requesting a base field no longer trips the warning
  • unit-tests/test_command_enterprise.py:
    • Add test confirming base fields (user_id, email, team_uid, node_id, role_id, name) no longer trigger the warning
    • Add test confirming a genuinely unsupported column still triggers the warning, so real validation errors aren't masked

@sshrushanth-ks sshrushanth-ks self-assigned this Sep 24, 2026
@sshrushanth-ks
sshrushanth-ks marked this pull request as ready for review September 24, 2026 11:50
@craiglurey
craiglurey merged commit 036862a into release Sep 24, 2026
4 checks passed
@sk-keeper
sk-keeper deleted the enterprise-info-column-definition-fix branch September 24, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants