Skip to content

fix: address snyk findings and harden skills - #6

Merged
jeremy-london merged 1 commit into
mainfrom
address-snyk-audit
Apr 4, 2026
Merged

jeremy-london merged 1 commit into
mainfrom
address-snyk-audit

Conversation

@jeremy-london

Copy link
Copy Markdown
Member

Summary

This PR fixes some findings during initial release found through a Snyk scan. There is no vulnerability just general best practice. When a scanner sees password or the use of a password argument its best to find an alternative path or request an interactive input from the user to prevent any leaks or hallucinations.

keeper-admin SKILL had some language that cause this finding:

HIGH W007: Insecure credential handling detected in skill instructions.

Insecure credential handling detected (high risk: 1.00). The prompt includes explicit examples that pass passwords, tokens, and secret field values directly in commands (e.g., --password "master_pw", --field password=s3cur3, --token "XX:XXXXXXXXXX"), which would require the agent to handle or emit secret values verbatim if it generated similar commands or scripts.

keeper-setup SKILL had some language that caused these findings:

HIGH W007: Insecure credential handling detected in skill instructions.

Insecure credential handling detected (high risk: 1.00). The skill shows and instructs using a One-Time Access Token passed directly on the command line (ksm profile init --token "US:XXXXXXXXXX"), which encourages embedding a secret verbatim in commands/outputs.
MEDIUM W012: Unverifiable external dependency detected (runtime URL that controls agent).

Potentially malicious external URL detected (high risk: 0.80). The skill instructs runtime fetching and installation of remote code (git clone https://github.com/Keeper-Security/Commander followed by pip install -r requirements.txt && pip install -e . and links to binary installers at https://github.com/Keeper-Security/secrets-manager/releases), which will download and execute external code on the host, so these URLs are runtime dependencies that can execute code.

Related issue

Type of change

  • Documentation (skills, references, README, etc.)
  • Plugin / marketplace metadata (.claude-plugin/or .cursor-plugin/)
  • CI / tooling (workflows, hooks, Taskfile)
  • Other (describe below)

@jeremy-london jeremy-london self-assigned this Apr 4, 2026
@jeremy-london
jeremy-london requested a review from a team as a code owner April 4, 2026 01:21
@jeremy-london
jeremy-london merged commit 23efabf into main Apr 4, 2026
2 checks passed
@jeremy-london
jeremy-london deleted the address-snyk-audit branch April 4, 2026 01:21
@github-actions github-actions Bot mentioned this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant