feat(action): command-mode inputs + built-in matrix names#70
Merged
Conversation
…Hub Action Wire the command/binary validation mode (PR #65) into the composite action so a project can gate CI on its own loader in one step: - new inputs `command`, `command-binary`, `command-expect-exit`; `artifact` becomes optional when `command` is set (mirrors the CLI). - free-text inputs flow through the step environment, never inline `${{ }}` interpolation, so they cannot inject host-side shell syntax. - built-in matrix convenience: a bare `matrix` name that does not exist in the caller repo resolves to the matching matrices/<name>.yaml shipped with the action — `matrix: quirk-library` gives the library of known-tricky vendor kernels with no file to copy. - README: command-mode Action example + drop the stale "self-hosted runner" marketplace step (hosted ubuntu-latest exposes /dev/kvm). - docs/command-validation.md: GitHub Action section. Verified by extracting the run script and exercising all branches with a fake binary: command mode + builtin matrix, artifact regression, command-binary-without-command error, hostile command string (single argv, no host execution), expect-exit forwarding. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires the command/binary validation mode into the composite GitHub Action, so a project can gate CI on its own loader in one step — the capability Falco's and vimto's maintainers both asked for, now first-class in the Action:
Changes
command,command-binary,command-expect-exit;artifactbecomes optional whencommandis set (mirrors the CLI contract).${{ }}interpolation, so a hostilecommandstring cannot inject host-side shell syntax.matrixvalue that doesn't exist in the caller repo resolves to the matchingmatrices/<name>.yamlshipped with the action —quirk-libraryworks with no file to copy.ubuntu-latestexposes/dev/kvm).docs/command-validation.md: GitHub Action section.Verification
Extracted the composite run script and exercised every branch against a fake binary:
quirk-library→ resolves to the action'smatrices/, forwards--command/--command-binary, omits--artifact✅command-binarywithoutcommand→::error✅"; touch PWNED; echo ") → stays one argv, file never created ✅command-expect-exit: 2→ forwarded ✅🤖 Generated with Claude Code