Add support for bootstrap4 custom breakpoints#9
Open
jhotadhari wants to merge 1 commit intoKevinBon:developfrom
Open
Add support for bootstrap4 custom breakpoints#9jhotadhari wants to merge 1 commit intoKevinBon:developfrom
jhotadhari wants to merge 1 commit intoKevinBon:developfrom
Conversation
|
I love the idea. You could also add a way to customize breakpoints via extension settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
its just a proposal.
I don't need that feature actually. no rush.
Added a function to extract all bs4 breakpoints from from
:rootstyle properties.Why? Usecase
For example a project, that overwrites the
$grid-breakpointsvariable:Results to this

:rootstyle properties:The custom breakpoint icon will use the default text color:

Disadvantages
Couldn't find a direct way to extract the breakpoint properties. Therefor its done with a loop, which takes time.
For me, it's around 5-8ms per pageload.
May be this feature might be better to opt out on default.