Skip to content

Clarify read-only settings snapshots and shared transaction plumbing - #157

Merged
KeyffMS merged 7 commits into
mainfrom
agent/issues-121-122-settings-read-transactions
Sep 24, 2026
Merged

KeyffMS merged 7 commits into
mainfrom
agent/issues-121-122-settings-read-transactions

Conversation

@KeyffMS

@KeyffMS KeyffMS commented Sep 24, 2026

Copy link
Copy Markdown
Owner

Addresses #121 and #122.

Changes:

  • exposes SettingsCoordinator.Current as IReadOnlySightAdaptSettings while retaining defensive-copy behavior;
  • changes configuration/runtime read paths to consume read-only snapshots;
  • introduces one lightweight SettingsUseCaseContext for shared snapshot/event/commit plumbing across configuration and visual-profile use cases;
  • consolidates Commit and PersistCurrent through one private transaction/persistence execution path;
  • preserves the rule that only successful Commit publishes Changed, while PersistCurrent does not;
  • keeps unexpected failures reported and rethrown;
  • adds tests for the read-only public contract and PersistCurrent event behavior;
  • updates architecture documentation.

No repository abstraction, generic command framework or inheritance hierarchy is introduced.

Addresses #121 and #122.

Signed-off-by: KeyffMS <124252104+KeyffMS@users.noreply.github.com>
Addresses #122.

Signed-off-by: KeyffMS <124252104+KeyffMS@users.noreply.github.com>
…ases.cs

Addresses #121 and #122.

Signed-off-by: KeyffMS <124252104+KeyffMS@users.noreply.github.com>
…ases.cs

Addresses #121 and #122.

Signed-off-by: KeyffMS <124252104+KeyffMS@users.noreply.github.com>
Addresses #121.

Signed-off-by: KeyffMS <124252104+KeyffMS@users.noreply.github.com>
Addresses #121 and #122.

Signed-off-by: KeyffMS <124252104+KeyffMS@users.noreply.github.com>
Addresses #121 and #122.

Signed-off-by: KeyffMS <124252104+KeyffMS@users.noreply.github.com>
@KeyffMS
KeyffMS merged commit 10e3e64 into main Sep 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant