Skip to content

Conversation

@EasyVulkan
Copy link

From the current description of VkSurfacePresentModeCompatibilityKHR:

Otherwise, presentModeCount must point to a variable set by the application to the number of elements in the pPresentModes array,

Apparently a copy / paste error. VkSurfacePresentModeCompatibilityKHR::presentModeCount is not a pointer.

Change it to:

Otherwise, presentModeCount must be set by the application to the number of elements in the pPresentModes array,

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2025

CLA assistant check
All committers have signed the CLA.

@oddhack
Copy link
Contributor

oddhack commented Jan 3, 2026

@cubanismo agreed this is a cut & paste error, probably from when we were getting the array query language more consistent. Please ask SI TSG to sign off.

written to pname:pPresentModes.
Otherwise, pname:presentModeCount must: be set by the application to the
number of elements in the pname:pPresentModes array, and on return the
variable is overwritten with the number of values actually written to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also drop "the variable" here since it is a product of the indirection language removed above it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also drop "the variable" here since it is a product of the indirection language removed above it?

Descriptions of following variables use the exactly same phrase "and on return the variable is ...":

// In limits.adoc
	layeredApiCount
	copyDstLayoutCount
	copySrcLayoutCount

// In wsi.adoc
	presentModeCount
	presentationTimingCount
	timingCount

Remove "the variable" from all these descriptions?

Copy link
Contributor

@cubanismo cubanismo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve inline feedback and fix CI issues.

@cubanismo
Copy link
Contributor

SI TSG Discussion Today: Approved once CI and feedback above are resolved. Assigning @EasyVulkan to follow-up.

Copy link
Contributor

@cubanismo cubanismo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I didn't realize this wording was so widespread. Regardless, the new wording sounds better to me.

@cubanismo
Copy link
Contributor

Note: Ignore the copyright date check CI failures for now. Something isn't working right there. I manually verified the copyright was correctly updated for the files this change touches.

@oddhack
Copy link
Contributor

oddhack commented Jan 9, 2026

Ah I didn't realize this wording was so widespread. Regardless, the new wording sounds better to me.

We tried to harmonize all the array query language a while back. In this case the pattern is ", and on return pname:{name of member} is overwritten...". The more common case is "pname:foo points to a variable ... and on return the variable is overwritten" but that's not for queries where the count is inside a structure.

As for CI that will continue to break until I push the next spec update from gitlab later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants