feat(bot): handle pr and mr comment requests#3427
Conversation
| export function createGitLabBotPlatform(): BotPlatform { | ||
| return { | ||
| platform: PLATFORM.GITLAB, | ||
| documentationUrl: 'https://kilo.ai/docs/code-with-ai/platforms/slack', |
There was a problem hiding this comment.
WARNING: Wrong documentation URL — points to the Slack platform page instead of GitLab.
documentationUrl is set to 'https://kilo.ai/docs/code-with-ai/platforms/slack'. This will misdirect any user or tooling that follows this URL. It should point to the GitLab-specific docs page (or a placeholder if that page doesn't exist yet).
| documentationUrl: 'https://kilo.ai/docs/code-with-ai/platforms/slack', | |
| documentationUrl: 'https://kilo.ai/docs/code-with-ai/platforms/gitlab', |
| } | ||
|
|
||
| const merged = { ...existing, ...metadataUpdates }; | ||
| if (existing.bot_enabled === false && metadataUpdates.bot_enabled === true) { |
There was a problem hiding this comment.
WARNING: bot_enabled can never be re-enabled once disabled.
This guard prevents re-enabling the bot via a GitHub App re-installation or any other path that passes { bot_enabled: true }. Once an admin disables the bot by setting bot_enabled: false, there is no programmatic way to flip it back to true — every install/update call will silently be overridden back to false here.
If the intent is to make bot_enabled: false sticky, this is a one-way door with no escape hatch. Consider whether an explicit admin action (e.g. a dedicated tRPC mutation) is needed to override this, or at minimum document why re-enabling via installation is intentionally blocked.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe GitLab bot platform has a wrong documentation URL pointing to the Slack docs, and a logic gate in Overview
Issue Details (click to expand)WARNING
Files Reviewed (14 files)
Fix these issues in Kilo Cloud Reviewed by claude-sonnet-4.6 · 4,282,507 tokens Review guidance: REVIEW.md from base branch |
Summary
Verification
Visual Changes
N/A
Reviewer Notes
Existing GitLab project webhooks need to be synced or updated so they send note events.