Fix camera display order to be idempotent across loads and pipefiles - #1857
Open
romleiaj wants to merge 2 commits into
Open
Fix camera display order to be idempotent across loads and pipefiles#1857romleiaj wants to merge 2 commits into
romleiaj wants to merge 2 commits into
Conversation
romleiaj
force-pushed
the
dev/camera-display-order
branch
from
August 20, 2026 14:51
068462f to
cc04d45
Compare
camMap's key order is insertion order: cameras are added one at a time inside an awaited per-camera load loop, and entries can survive a dataset switch, so it is not a dependable statement of rig order. Anything where "which camera is first/last" carries meaning -- the registration reference camera, the direction a loop-closure residual is measured in -- needs the order the dataset actually persists. Add displayOrder, published by the viewer from orderedMultiCamCameraNames at load (and cleared on single-camera datasets so a previous rig's order cannot leak), and orderedCameraNames() to read it back restricted to cameras present, falling back to camMap order when no order has been set. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014S8CVLjQDzaBGbCSKL7FiF (cherry picked from commit c5464db)
The registration panel, multicam tools/toolbar and the per-camera registration import buttons listed cameras in camMap insertion order, which is load-completion order and can differ from one open to the next (EO/UV/IR one time, EO/IR/UV the next). Read CameraStore.orderedCameraNames() instead, which follows the dataset's persisted cameraOrder -- the same order the viewer tabs and the 2-cam/3-cam pipeline inputs use. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MD6kx1uDv4NuiKdFNnYpG2
romleiaj
force-pushed
the
dev/camera-display-order
branch
from
August 20, 2026 14:57
cc04d45 to
4025b73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.