Dev/auto register fixes - #1860
Open
romleiaj wants to merge 8 commits into
Open
Conversation
The collapse only fired for the left sidebar, so opening Camera Registration with the sidebar in bottom mode left it up, competing for the vertical room the two picking panes need. Collapse it either way; the prior mode is still restored on close and the toggle still works while registering. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
The sidebar isn't useful during picking and the bottom layout in particular doesn't lay the picking panes out usably. The panel already collapses the sidebar on open and restores it on close; hide the toggle in between so it can't be turned back on there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
Full camera names overflowed the button toggle; the full pair names move to the buttons' native tooltips. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
…dout Long camera names overflowed the monospace readout the same way they did the Overlay Warp toggle; same L/R shorthand, same active-pair cameras. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
Long camera names overflowed the block button; the full label (camera -> destination) is now an ellipsis-truncated line backed by the button's native title tooltip on hover. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
VideoAnnotator only bumped imageRevision once, right after loadedmetadata; every later scrub left the aligned-view canvas warp showing whatever the <video> element displayed mid-seek (often black) because nothing told it to redraw once the seek actually landed. The native (unwarped) pane never showed this since the browser keeps a <video> element live on its own -- only the canvas snapshot needed the signal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
The frame-number watch repainted immediately on every seek to blank a per-slot gap -- a case video panes never hit (VideoAnnotator's seek() treats it as unreachable by construction) -- and at that instant the browser hasn't decoded the target frame yet, so the repaint only ever caught the stale pre-seek frame. That stale paint, followed moments later by the correct one once 'seeked' bumps imageRevision, read as a flicker on every scrub step. Video panes now skip the immediate repaint and rely solely on the imageRevision-triggered one; image panes are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
Same unbounded label as the desktop export menu, same fix: ellipsis the line and keep the full camera/destination in the button's title tooltip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K9imLktmzCkAR3wmUybaEs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.