Skip to content

Add typing to controller_decorator #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jourdain merged 2 commits into from
Oct 8, 2026
Merged

Add typing to controller_decorator #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc77bd7
chore: add typing to controller_decorator
MattTheCuber Oct 8, 2026
f1b644f
chore: format code
MattTheCuber Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/trame_common/decorators/klass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
import inspect
import logging
from collections.abc import Callable
from typing import Any, TypeVar
from typing import Any, ParamSpec, TypeVar

F = TypeVar("F", bound=Callable[..., Any])
P = ParamSpec("P")
R = TypeVar("R")

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -128,9 +130,11 @@ def decorate(f: F) -> F:
return decorate


def controller_decorator(method):
def decorator(*args):
def decorate(f):
def controller_decorator(
method: str,
) -> Callable[..., Callable[[Callable[P, R]], Callable[P, R]]]:
def decorator(*args: str) -> Callable[[Callable[P, R]], Callable[P, R]]:
def decorate(f: Callable[P, R]) -> Callable[P, R]:
if not hasattr(f, "_trame_controller"):
f._trame_controller = []
for name in args:
Expand Down
Loading