[ColourRole] fix unexpected error due to cooldown#228
Draft
slushiegoose wants to merge 3 commits intomasterfrom
Draft
[ColourRole] fix unexpected error due to cooldown#228slushiegoose wants to merge 3 commits intomasterfrom
slushiegoose wants to merge 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 83.48% 83.46% -0.02%
==========================================
Files 27 27
Lines 6671 6672 +1
==========================================
Hits 5569 5569
- Misses 1102 1103 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Kaspiaan
requested changes
Aug 8, 2021
Member
Kaspiaan
left a comment
There was a problem hiding this comment.
Please also add changes made to the changelog, you can pretty much put the issue name under a Colour Role heading
Kaspiaan
requested changes
Aug 8, 2021
Kaspiaan
approved these changes
Aug 9, 2021
Contributor
|
CodeCoverage Fails after 1s - Need to take a look at. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #216 by fixing the unexpected error due to cooldown
Checklist
CHANGELOG.mdunder the[Unreleased]heading?documentation.json?