Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 82.27% 82.40% +0.13%
==========================================
Files 26 27 +1
Lines 6453 6560 +107
==========================================
+ Hits 5309 5406 +97
- Misses 1144 1154 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Kaspiaan
reviewed
Aug 8, 2021
Kaspiaan
reviewed
Aug 8, 2021
cogs/ReactForRole.py
Outdated
| """ | ||
| sql_create_inline_all_status_table = """ | ||
| CREATE TABLE IF NOT EXISTS InlineAllStatus ( | ||
| guild_id integer NOT NULL, |
Member
There was a problem hiding this comment.
guild_id should be text, this is fine for now as I can change it later.
Member
There was a problem hiding this comment.
Best to change now, removes the need for changing later
Author
There was a problem hiding this comment.
Changed guild_id to be text
Member
|
Code coverage of tests needs increasing pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #195
Checklist
CHANGELOG.mdunder the[Unreleased]heading?documentation.json?