Skip to content

Fixed: Bug #196 permissions reset when creating rfr #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jplam123 wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fixed: Bug #196 permissions reset when creating rfr #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7e58d9
Fixed: Bug, #196 permissions reset when creating rfr
jplam123 Aug 4, 2021
bf4a27a
feat: added change to CHANGELOG
jplam123 Aug 4, 2021
081a1d6
Merge branch 'master' into WESVGBug
jplam123 Aug 6, 2021
5243ee7
Merge branch 'master' into WESVGBug
Kaspiaan Oct 19, 2021
781bcde
Changed line as perms.add_reactions = False is not valid
Kaspiaan Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ All notable changes to KoalaBot will be documented in this file. A lot of these
administrators

## [Unreleased]
### ReactForRole
- Fixed issues with permissions for a text channel resetting when a react for role is created.

## [0.4.5] - 25-08-2021
### Other
Expand Down
7 changes: 4 additions & 3 deletions cogs/ReactForRole.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,10 +942,11 @@ async def overwrite_channel_add_reaction_perms(self, guild: discord.Guild, chann
"""
# Get the @everyone role.
role: discord.Role = discord.utils.get(guild.roles, id=guild.id)
overwrite: discord.PermissionOverwrite = discord.PermissionOverwrite()
overwrite.update(add_reactions=False)
await channel.set_permissions(role, overwrite=overwrite)
perms = channel.overwrites_for(role)
Comment on lines 944 to +945
Copy link
Member

@JayDwee JayDwee Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All current roles should have the add_reactions perm set to false, not just everyone. (although this successfully doesn't screw with other perms, as mentioned in issue, gj!)

perms.update(add_reactions=False)
await channel.set_permissions(role, overwrite=perms)
bot_members = [member for member in guild.members if member.bot and member.id == self.bot.user.id]
overwrite: discord.PermissionOverwrite = discord.PermissionOverwrite()
overwrite.update(add_reactions=True)
for bot_member in bot_members:
await channel.set_permissions(bot_member, overwrite=overwrite)
Expand Down