Repository navigation
feat(aigw): Install 2.x on prem - #7622
Draft
cloudjumpercat wants to merge 2 commits into
Draft
cloudjumpercat wants to merge 2 commits into
cloudjumpercat wants to merge 2 commits into
Conversation
…oduct versions Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The hyphenated-slug bug fixed in this PR had no test coverage. Covers non-hyphenated slugs, hyphenated slugs (ai_gateway_latest), and products without releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7431
TODO (must haves):
deck ai syncas a next step so they understand how to actually use their on prem AIGWTODO (nice to have):
Preview Links
/ai-gateway/install/docker/
Also included a fix that Claude made so that hyphenated products can use the latest_version liquid tag. From Claude:
site.data['products']is keyed by the literal filename slug (ai-gateway,hyphenated — Jekyll doesn't normalize data-directory keys). But
producthereis already
ai_gateway(underscored) by the time it's used indig('products', product, 'releases'), so the lookup misses,releasesisnil, andsite.data['ai_gateway_latest']is silently never set.This affects every hyphenated product slug, confirmed via
ls app/_data/products/:ai-gateway,context-mesh,dev-portal,event-gateway,konnect-reference-platform. A repo-wide grep for[a-z_]+_latest\bturned up real usage only for non-hyphenated slugs(
gateway_latest,mesh_latest,operator_latest,kic_latest,insomnia_latest— all unaffected since the gsub is a no-op on them) plusexactly one hit for
ai_gateway_latest(the how-to we just wrote) — so thisbug has never actually been exercised against one of the broken slugs before
now, which is why nobody caught it.
Checklist
descriptionentry in frontmatter.