Skip to content

ci: add rust-toolchain.toml reproducible builds#122

Open
KooshaPari wants to merge 1 commit into
mainfrom
fix/add-rust-toolchain
Open

ci: add rust-toolchain.toml reproducible builds#122
KooshaPari wants to merge 1 commit into
mainfrom
fix/add-rust-toolchain

Conversation

@KooshaPari
Copy link
Copy Markdown
Owner

@KooshaPari KooshaPari commented May 7, 2026

User description

Adds MSRV policy BytePort.


Note

Low Risk
Low risk change that only affects developer/CI toolchain selection; main risk is unexpected breakage if the code depends on a different Rust version or missing components in some environments.

Overview
Pins Rust builds by adding rust-toolchain.toml that selects the stable channel and ensures rustfmt, clippy, and rust-src are installed for consistent CI and local development tooling.

Reviewed by Cursor Bugbot for commit 79ff771. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Pin the Rust toolchain for consistent builds and local tooling

What Changed

  • Rust builds now use the stable toolchain by default
  • Common developer tools for formatting, linting, and Rust source support are installed automatically
  • Local development and CI are more likely to use the same Rust version and tooling

Impact

✅ More consistent Rust builds
✅ Fewer formatting and linting setup issues
✅ Smoother local development setup

🔄 Retrigger CodeAnt AI Review

Details

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI review requested due to automatic review settings May 7, 2026 20:24
@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 7, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label May 7, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a rust-toolchain.toml file to define the project's Rust environment. Feedback suggests pinning the toolchain to a specific version (1.77.2) rather than using the "stable" channel to ensure build reproducibility and alignment with the project's minimum supported Rust version.

Comment thread rust-toolchain.toml
@@ -0,0 +1,3 @@
[toolchain]
channel = "stable"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR title mentions 'reproducible builds', but using channel = "stable" means the toolchain will automatically update whenever a new stable version of Rust is released. To ensure true reproducibility and align with the MSRV defined in frontend/web/src-tauri/Cargo.toml (which is 1.77.2), you should pin a specific version here.

Suggested change
channel = "stable"
channel = "1.77.2"

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 79ff771. Configure here.

Comment thread rust-toolchain.toml
@@ -0,0 +1,3 @@
[toolchain]
channel = "stable"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toolchain channel "stable" breaks version detection regex

Medium Severity

Setting channel = "stable" in rust-toolchain.toml breaks the Rust runtime version detection in backend/nvms/lib/awsutil.go, which uses the regex channel = ["'](\d+\.\d+)["'] to extract a numeric version from this file. The string "stable" won't match, so the buildpack will fail to detect the Rust version. Additionally, "stable" doesn't define an MSRV or provide reproducible builds as the PR intends — it floats to whatever the latest stable release is.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 79ff771. Configure here.

@codeant-ai
Copy link
Copy Markdown

codeant-ai Bot commented May 7, 2026

CodeAnt AI finished reviewing your PR.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 7, 2026

Code Review Summary

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
WARNING 2
Issue Details (click to expand)

WARNING

File Line Issue
rust-toolchain.toml 2 Using channel = "stable" breaks reproducibility - should pin to specific version (e.g., 1.77.2) to match MSRV defined in frontend/web/src-tauri/Cargo.toml
rust-toolchain.toml 2 The value "stable" breaks the Rust version detection regex in backend/nvms/lib/awsutil.go (line 226) expecting a numeric version pattern
Files Reviewed (1 file)
  • rust-toolchain.toml - 2 issues

Reviewed by laguna-m.1-20260312:free · 655,259 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants