Skip to content

Comments

Migrate to Starscream#16

Open
DamianSullivanCiti wants to merge 1 commit intoKoredotcom:masterfrom
DamianSullivanCiti:feature/starscream
Open

Migrate to Starscream#16
DamianSullivanCiti wants to merge 1 commit intoKoredotcom:masterfrom
DamianSullivanCiti:feature/starscream

Conversation

@DamianSullivanCiti
Copy link

Replace SocketRocket with Starscream.

@SrinivasVa-Kore
Copy link
Contributor

@DamianSullivanCiti Thanks for your pull request.

Currently we and our customers are not facing any issues with SocketRocket. We have a plan to migrate objective-C dependencies to Swift in KoreBotSDK.

We will merge this pull request once QA certifies it.

@DamianSullivanCiti
Copy link
Author

Thanks! FYI the reasons we need it are

Self Signed SSL
Our servers use self signed SSL, and SocketRocket doesn't work with self signed SSL. Starscream has support build in. https://github.com/daltoniam/Starscream#self-signed-ssl

Blackberry Dynamics
Our servers aren't accessibly on the internet, we have to access through Blackberry Dynamics. Blackberry dynamics doesn't support web sockets at all, however we forked Starscream and build a websocket implementation which works over Blackberry Dynamics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants