recipes: drop 8 recipes that don't need one - #8
Merged
Merged
Conversation
Per review feedback: these packages all ship a universal (py3-none-any)
wheel and have no dependencies that themselves need native compilation
or lack a wheel, so a p4a recipe adds nothing over just listing them in
an app's requirements (or another recipe's python_depends) -- they get
pip-installed exactly like `colorama`, `certifi`, `idna`, `urllib3` etc.
already are.
materialshapes, meteofrance-api, mpmath, pydantic, pywizlight,
simplemma, sympy, tibs
pydantic-core (the compiled Rust part pydantic itself pins) already has
its own recipe; tibs was only ever a speculative companion to a newer
bitstring version this doesn't use (see below), nothing depends on it.
Kept as recipes, despite also having universal wheels themselves,
because their own dependency chain includes something that doesn't:
- jsonschema -- needs rpds-py, which is Rust-compiled with no
universal wheel and no recipe of its own yet.
- bitstring -- current PyPI releases need bitarray and tibs, both
compiled; pinning the last version that doesn't (3.1.9) is this
recipe's whole point, not building anything.
- lifxlan -- pulls in bitstring unconstrained; without a recipe (or
without --no-deps carving an explicit exception) pip would resolve
a bitstring version needing a bitarray build that doesn't work
here, exactly the crash this was hit and fixed for while building
the app this PR is drawn from.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
Author
|
Ces 8 recettes ne sont pas perdues : elles sont conservées dans https://github.com/Krozark/p4a-recipes (réutilisables via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same cleanup as proposed upstream (kivy#3384), verified none of these are actually wired into AVA's build (no recipe/requirement references them):
Dropped:
materialshapes,meteofrance-api,mpmath,pydantic,pywizlight,simplemma,sympy,tibs— all ship a universal wheel, and their own dependencies don't need compilation either. They'll just be pip-installed likecolorama/certifi/idnaalready are, sincemeteofrance-apiandpywizlightare named directly inbuildozer.spec'srequirements.materialshapes,mpmath,simplemma,sympy,pydantic,tibsweren't referenced by anything (nodepends, not inrequirements) — dead recipes, never actually built into the app.Kept:
jsonschema,bitstring,lifxlan— their own dependency chains need something that doesn't have a universal wheel (rpds-pyfor jsonschema;bitarray/tibsfor currentbitstring, which is why that recipe pins 3.1.9 rather than building anything).🤖 Generated with Claude Code