test: kubectl-dns secret-generation command#841
Open
averevki wants to merge 1 commit intoKuadrant:mainfrom
Open
test: kubectl-dns secret-generation command#841averevki wants to merge 1 commit intoKuadrant:mainfrom
averevki wants to merge 1 commit intoKuadrant:mainfrom
Conversation
Signed-off-by: averevki <sandyverevkin@gmail.com>
Contributor
Author
|
/make smoke |
|
Test run completed ( Short Test SummaryFull Output |
Contributor
Author
|
/make smoke |
|
Test run completed ( Short Test SummaryFull Output |
azgabur
reviewed
Feb 6, 2026
| obj.context = self.context | ||
| return obj | ||
|
|
||
| def create_merged_kubeconfig(self, cluster2: "KubernetesClient") -> str: |
Member
There was a problem hiding this comment.
Due to coredns tests we will probably deal with more then two clusters, maybe refactor this method to take list of additional clusters? wdyt?
Contributor
Author
There was a problem hiding this comment.
I'm not sure if we should have other tests running this command. I would leave it for when a new test is being developed
testsuite/tests/multicluster/coredns/two_clusters/kubectl_dns/test_secret_generation.py
Show resolved
Hide resolved
| def kubeconfig_secrets(request, testconfig, cluster, cluster2, kubectl_dns, blame): | ||
| """Run generate-secret command on merged kubeconfig to generate kubeconfig secret for the secondary cluster""" | ||
| system_project = testconfig["service_protection"]["system_project"] | ||
| secret_name = blame("kubecfg") |
Member
There was a problem hiding this comment.
Would use tempfile library for a temporary file. Also there is missing finalizer for removing it.
Contributor
Author
There was a problem hiding this comment.
Binary creates this secret directly on cluster. I have finalizer set right under this comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kubectl-dnsCLI tool integration to the test suitekubectl-dns secret-generationcommandkuadrantctlinto a dedicatedtestsuite/cli/moduleVerification steps
Run the new test:
Note: This test requires:
certificate-authoritykey with the cluster CA. You can set it for a kubeconfig by logging in with explicitly specified path to the cluster CA, aka.oc login --username=${} --password=${} <clusterapiurl> --certificate-authority=path/to/ca