Use a small Material triangle for settings expander disclosure icon#401
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the shared settings-dialog CollapsibleSection widget to use a small Material disclosure triangle (instead of Qt’s native arrow primitive) so expander indicators are consistently themed and appropriately sized across dialogs.
Changes:
- Replace
QToolButton.setArrowType()usage withqt_material_icons.MaterialIconfor collapsed/expanded disclosure indicators. - Set the disclosure icon size to 16px and swap icons on toggle.
- Add a UI test ensuring the icon changes on expand/collapse and that no native arrow is used.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/jabs/ui/settings_dialog/collapsible_section.py | Switches disclosure indicator from native arrow to Material icons and updates toggle behavior to swap icons. |
| tests/ui/test_settings_dialog.py | Adds a regression test covering disclosure icon swapping and verifying NoArrow is used. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collapsible "More info" sections in the settings dialogs used
QToolButton.setArrowType(), which draws the Qt style's arrow primitive — chunky and not easily sized.This swaps it for a small Material disclosure triangle in the shared
CollapsibleSectionwidget:arrow_rightwhen collapsed,arrow_drop_downwhen expanded, at 16px.qt_material_icons, which renders in the palette text color, so it follows the application theme (matching how sibling dialogs already useMaterialIcon).arrowTypeis nowNoArrow); the toggle/resize behavior is otherwise unchanged.Because it's the shared widget, every settings "More info" expander updates consistently.
Tests
test_collapsible_section_toggles_disclosure_icon: verifies the icon swaps on expand and reverts on collapse, and that no native arrow is drawn.It's a visual tweak, so a quick look in the GUI confirms the appearance; the toggle behavior is covered by the test.