Document actual test mocking convention (monkeypatch + unittest.mock)#404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.md's Testing section lists
pytest-mockas a tool and shows amocker: MockerFixtureexample, butpytest-mockis not declared in anypyproject.tomland is not installed — themockerfixture raises "fixture 'mocker' not found". This aligns the documentation with the actual, already-consistent convention.Why docs, not the dependency
The codebase already mocks consistently without pytest-mock:
mockerunittest.mock, 13 usemonkeypatchunittest.mock+ the built-inmonkeypatchfixture are stdlib / pytest built-ins and already the de-facto standard here. Adoptingpytest-mockwould mean adding the dep to all 5 workspacetestgroups and either a mixed convention or a 42-file migration for marginal ergonomic gain. The actual problem was the doc, not a missing tool.Changes
pytest-mockfrom the Framework & Tools list; add an explicit "Mocking" bullet pointing tomonkeypatch+unittest.mockand notingmockeris not available.mocker: MockerFixtureexample to useunittest.mock.Mock, plus a shortmonkeypatch.setattr(...)example for patching module-level symbols.Docs-only; no code or tests affected.
🤖 Generated with Claude Code