Add script to update housingSearch for assets using the Asset.fifo topic#6
Add script to update housingSearch for assets using the Asset.fifo topic#6LBHCallumM wants to merge 7 commits into
Conversation
LBHCallumM
changed the title
| # 2) Call functions here | ||
|
|
||
| update_boilerhouse() | ||
| update_properties() |
There was a problem hiding this comment.
I would leave this function commented out, if eventually this gets pushed to master.
Whoever uses this repo should change this file before running anything
There was a problem hiding this comment.
Looks tidy.
I would make some small edits (see comments) if you eventually decide to push this to master, however I would not merge until you're 100% sure the script is robust (I know as I've had to modify my script numerous time to add error handlings/checks) .
Maybe these script should be merge only after they've been run on dev, staging and prod.
|
|
||
| @dataclass | ||
| class User: | ||
| NAME = "Callum Macpherson" |
There was a problem hiding this comment.
I would remove your name and email, again, if you decide to push to master
| response = sns_client.publish( | ||
| TopicArn=Config.SNS_TOPIC_ARN, | ||
| Message=sns_message, | ||
| MessageGroupId="fake", |
There was a problem hiding this comment.
Why fake? Is any string value ok here?
2 participants
No description provided.