Skip to content

Bugfix to alembic path.#456

Open
cmccully wants to merge 2 commits intomainfrom
fix/alembic
Open

Bugfix to alembic path.#456
cmccully wants to merge 2 commits intomainfrom
fix/alembic

Conversation

@cmccully
Copy link
Copy Markdown
Collaborator

@cmccully cmccully commented Apr 9, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Alembic migration configuration so that running Alembic with banzai/alembic.ini correctly finds the migration scripts under banzai/alembic, and bumps the package version/changelog accordingly.

Changes:

  • Bump package version to 1.34.1.
  • Add a 1.34.1 entry to CHANGES.md describing the fix.
  • Update Alembic script_location to point at the alembic/ subdirectory.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Version bump to 1.34.1 for the release containing the fix.
CHANGES.md Adds release notes for 1.34.1.
banzai/alembic.ini Fixes Alembic script_location so migrations resolve correctly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGES.md
1.34.1 (2026-04-09)
-------------------

- bugfix to alembic path
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry uses lowercase and is a bit vague compared to surrounding entries (which use sentence case and more specific wording). Consider updating this bullet to sentence case and explicitly mentioning the Alembic script_location/migration script path fix for consistency and clarity.

Suggested change
- bugfix to alembic path
- Fix Alembic `script_location`/migration script path handling.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants