Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the permission signature check bypass to cover Android 16 by matching any preparePackage* method instead of only preparePackageLI, and adds version-specific references.
- Broadens stack-trace check to match
preparePackage*methods - Adds comments linking to Android source references for R-Sv2, T-V, and Android 16
- Replaces the old method-name equality check with a prefix-based check
Comments suppressed due to low confidence (3)
app/src/main/java/toolkit/coderstory/CorePatchForR.java:273
- [nitpick] Verify the preference key "digestCreak" is spelled correctly; it may be a typo for "digestCrack" which could lead to unexpected defaults.
if (prefs.getBoolean("digestCreak", true) &&
app/src/main/java/toolkit/coderstory/CorePatchForR.java:274
- Matching any method starting with "preparePackage" may be too broad and could allow unintended bypasses; consider restricting to specific method names or verifying the caller class.
.anyMatch((o) -> o.getMethodName().startsWith("preparePackage"))
app/src/main/java/toolkit/coderstory/CorePatchForR.java:273
- There are no tests covering this new bypass logic for Android 16; adding unit or integration tests will help ensure future changes don’t break it.
if (prefs.getBoolean("digestCreak", true) &&
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.