Skip to content

native: configurable ready timeout #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
john-a-joyce wants to merge 2 commits into
base: main
Choose a base branch
from
Open

native: configurable ready timeout #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba05a0
native: configurable ready timeout
Jun 30, 2026
26a181f
Updates based on PR comments.
Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,12 @@ munet>
description
"Shell command[s] to execute to determine if the node is ready";
}
leaf ready-timeout {
type uint32;
default 30;
description
"Maximum time in seconds to wait for the node to become ready.";
}
leaf image {
type string;
must "not(../hostnet) and not(../qemu) and not(../server)" {
Expand Down
6 changes: 6 additions & 0 deletions munet/munet-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@
"ready-cmd": {
"type": "string"
},
"ready-timeout": {
"type": "integer"
},
"image": {
"type": "string"
},
Expand Down Expand Up @@ -593,6 +596,9 @@
"ready-cmd": {
"type": "string"
},
"ready-timeout": {
"type": "integer"
},
"image": {
"type": "string"
},
Expand Down
13 changes: 12 additions & 1 deletion munet/native.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3586,7 +3586,18 @@ async def wait_until_ready(x):
tasks = [asyncio.create_task(wait_until_ready(x)) for x in ready_nodes]

logging.debug("Waiting for ready on nodes: %s", ready_nodes)
_, pending = await asyncio.wait(tasks, timeout=30)

# setable via "ready-timeout: 600" in kinds.yaml.
ready_timeout = max(
node.config.get("ready-timeout", 30) for node in ready_nodes
)
self.logger.info(
"waiting up to %ss for ready-cmd on %s ready nodes",
ready_timeout,
len(ready_nodes),
)

_, pending = await asyncio.wait(tasks, timeout=ready_timeout)
if pending:
logging.warning("Timeout waiting for ready: %s", pending)
for nr in pending:
Expand Down
Loading