Fix units soil moisture equation for ch - #321
Merged
Merged
Conversation
LINAMARIAOSORIO
requested review from
camilabillerbeck
and removed request for
soaressgabriel
August 28, 2026 14:28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 92.48% 92.48% -0.01%
==========================================
Files 60 60
Lines 3911 3910 -1
Branches 487 487
==========================================
- Hits 3617 3616 -1
Misses 238 238
Partials 56 56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
camilabillerbeck
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR fixes the calculation of the soil moisture condition coefficient
C_hinSurfaceRunoff.get_coef_soil_moist_conditions().The previous implementation mixed a dimensionless soil moisture quantity in the numerator with the saturation storage in millimeters in the denominator.
Related Issue
Motivation and context
How has this been tested
Screenshots