Skip to content

Fix units soil moisture equation for ch - #321

Merged
soaressgabriel merged 3 commits into
mainfrom
fix_318
Sep 2, 2026
Merged

Fix units soil moisture equation for ch#321
soaressgabriel merged 3 commits into
mainfrom
fix_318

Conversation

@LINAMARIAOSORIO

Copy link
Copy Markdown
Collaborator

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

This PR fixes the calculation of the soil moisture condition coefficient C_h in SurfaceRunoff.get_coef_soil_moist_conditions().

The previous implementation mixed a dimensionless soil moisture quantity in the numerator with the saturation storage in millimeters in the denominator.

Related Issue

Motivation and context

  • TBF

How has this been tested

  • TBF

Screenshots

  • N/A

@LINAMARIAOSORIO LINAMARIAOSORIO self-assigned this Aug 27, 2026
@LINAMARIAOSORIO
LINAMARIAOSORIO requested review from camilabillerbeck and removed request for soaressgabriel August 28, 2026 14:28
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.48%. Comparing base (92d45d6) to head (16922cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   92.48%   92.48%   -0.01%     
==========================================
  Files          60       60              
  Lines        3911     3910       -1     
  Branches      487      487              
==========================================
- Hits         3617     3616       -1     
  Misses        238      238              
  Partials       56       56              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soaressgabriel soaressgabriel changed the title Fix units soil moisture eqution for ch Fix units soil moisture equation for ch Aug 28, 2026
@soaressgabriel
soaressgabriel merged commit b64006a into main Sep 2, 2026
17 checks passed
@soaressgabriel
soaressgabriel deleted the fix_318 branch September 2, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C_h mixes dimensionless soil moisture with TUsat in mm

3 participants