You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hey, main now has stricter TypeScript (#735 just merged) which exposes a real type issue:
src/services/sorobanService.ts: error TS2352:
Conversion of type 'Hash' to type 'Uint8Array' may be a mistake
because neither type sufficiently overlaps with the other.
addr.contractId() returns Hash (a soroban-sdk type), not Uint8Array directly. The fix is to double-cast through unknown:
or use Buffer.from(addr.contractId()) if Hash has a toJSON / [Symbol.iterator]. Same change needed in both src/services/sorobanService.ts and src/workers/soroban-event-worker.ts.
once that's fixed plus a rebase on main, CI should clear.
still failing Backend CI on the same Hash to Uint8Array cast. Hash and Uint8Array don't structurally overlap in TS, so a direct cast won't satisfy the compiler. bridge through unknown:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…' cast
Description
close #638
Type of Change
Related Issues
Closes #
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes