Conversation
Implement: - Vector.filter / Matrix.filter - Vector.exists / Vector.forall (short-circuit || / &&) - Matrix.exists / Matrix.forall (short-circuit || / &&) Tests (64 total): - Vector.filter: 9 - Vector.exists: 12 - Vector.forall: 12 - Matrix.filter: 9 - Matrix.exists: 11 - Matrix.forall: 11 Benchmarks: - Filters.fs: Vector/Matrix filter (dense + sparse), N=64,256,4096 - Exists.fs: Vector/Matrix exists (dense + sparse), N=64,256,4096 - Forall.fs: Vector/Matrix forall (dense + sparse), N=64,256,4096 - Register in BenchmarkSwitcher and .fsproj
Member
|
Правда ли, что то, что Вы сделали, не выражается через map тривиальным образом, |
Author
filter выразить можно, но это было одной из моих задач в проекте |
narysh
changed the title
… test suite (188 tests)
gsvgit
requested changes
Sep 21, 2026
| ) | ||
| | Error e -> failwithf "unexpected error %A" e | ||
|
|
||
| [<Fact>] |
Member
There was a problem hiding this comment.
А чего ни одного Property-based теста?
| Assert.Equal(Ok(Some 11), get result 0UL<rowindex> 0UL<colindex>) | ||
| Assert.Equal(Ok(Some 121), get result 1UL<rowindex> 1UL<colindex>) | ||
|
|
||
| [<Fact>] |
| (Leaf(UserValue(res)), nnz) |> Ok | ||
| let get (matrix: SparseMatrix<'a>) (row: uint64<rowindex>) (col: uint64<colindex>) : Result<option<'a>, Error> = | ||
| if uint64 row >= uint64 matrix.nrows || uint64 col >= uint64 matrix.ncols then | ||
| Error Error.InvalidElementIndex |
Member
There was a problem hiding this comment.
Посмотрите, как обычно называется такая ситуация в .NET
| | LeftValuesOnlyIndexed of (uint64<rowindex> -> uint64<colindex> -> 'a -> Option<'b> -> Option<'c>) | ||
|
|
||
| let private applyBinary | ||
| (op: BinaryOp<'a, 'b, 'c>) |
Member
There was a problem hiding this comment.
А нельзя ли всё это дело как-то не копировать?
…ds access, deduplicate applyBinary
…COO to COOArray - COOArray: walk the sorted array with a cursor in full-cell cooMap/cooMapi paths and buffer results in ResizeArray instead of building a lookup Map; rewrite mergeBinary as a two-pointer merge over sorted arrays - COOArray/COOList: strengthen mxmcoo optimization detection by probing all distinct values rather than only the first entry - COOList: replace Map-based lookup in full-cell cooMap/cooMap2 with a pointer walk over the sorted list - Tests: add FsCheck property tests for mxmcoo against a naive reference and cross-checks between the array and list implementations - Benchmark: add list-backed get/set cases (COOLIST_get/set, resultListVal) to Format, DenseFormat and RealMatrix benchmarks - Rename module COO to COOArray for consistency with COOList: file rename, fsproj entries, open statements, test module, and Fantomas formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement:
Tests (64 total):
Benchmarks: