[lua, cpp] Assault Containerization + Framework#9827
Open
CriticalXI wants to merge 1 commit intoLandSandBoat:basefrom
Open
[lua, cpp] Assault Containerization + Framework#9827CriticalXI wants to merge 1 commit intoLandSandBoat:basefrom
CriticalXI wants to merge 1 commit intoLandSandBoat:basefrom
Conversation
Frankie-hz
reviewed
Apr 19, 2026
|
|
||
| // do not roam around | ||
| PMob->setMobMod(MOBMOD_ROAM_RESET_FACING, 1); | ||
| PMob->setMobMod(MOBMOD_ROAM_DISTANCE, 0); |
Contributor
There was a problem hiding this comment.
Mobs in assaults are supposed to roam, at least for most of them. I would remove this and apply it per assault if its needed.
Contributor
Author
There was a problem hiding this comment.
Main difference is that the mobs that need to roam in instances just need to not have the MOBTYPE_BATTLEFIELD not set in mob_pools. Unless there's a more obvious way to go about this. I just noticed this broke for mobs that do have that mobtype set in instances were still roaming when they shouldn't when I was testing this didn't break other instances.
Co-authored-by: Abdiah <62350957+dallano@users.noreply.github.com>
c61f8c8 to
4d1aee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Steps to test these changes