Skip to content

[lua, cpp] Assault Containerization + Framework#9827

Open
CriticalXI wants to merge 1 commit intoLandSandBoat:basefrom
CriticalXI:assault_framework
Open

[lua, cpp] Assault Containerization + Framework#9827
CriticalXI wants to merge 1 commit intoLandSandBoat:basefrom
CriticalXI:assault_framework

Conversation

@CriticalXI
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Continues the work done by @dallano to allow Assaults to utilize the container framework.
  • Corrects an issue with mobs in instances roaming slightly at the start by setting battlefield mobs to have 0 roam distance along with 0 max roam distance.
  • Fixes an issue with AfterZoneIn triggering updateCharLevelRestriction against players which would remove the existing level restriction placed on players.
  • Follow up PR coming converting all of the existing Assault IDs.lua to not utilize hard coded IDs and making the first initial Assault in this setup.

Steps to test these changes

  • Not currently testable, will be following up with another PR with initial assault mission to showcase utilizing this new framework.


// do not roam around
PMob->setMobMod(MOBMOD_ROAM_RESET_FACING, 1);
PMob->setMobMod(MOBMOD_ROAM_DISTANCE, 0);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobs in assaults are supposed to roam, at least for most of them. I would remove this and apply it per assault if its needed.

Copy link
Copy Markdown
Contributor Author

@CriticalXI CriticalXI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main difference is that the mobs that need to roam in instances just need to not have the MOBTYPE_BATTLEFIELD not set in mob_pools. Unless there's a more obvious way to go about this. I just noticed this broke for mobs that do have that mobtype set in instances were still roaming when they shouldn't when I was testing this didn't break other instances.

Co-authored-by: Abdiah <62350957+dallano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants