Repository navigation
test: cbwin-e2e waits for the DB lock when it renames shares - #100
Merged
Merged
Conversation
The 'cannot measure its window' stage renames the shares table from the sqlite3 CLI while the pool holds the DB open and retries its window query. The CLI has no busy timeout, so a rename that lands during the pool's lock fails at once with 'database is locked' (exit 5). It failed main on 2026-10-02 and PR #98 on 2026-10-12. Give all four renames a 10s busy timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cbwin-e2estage "a pool that cannot measure its window publishes NO job" renamessharesfrom thesqlite3CLI while the pool has the DB open and retries its window query on every poll. The CLI has no busy timeout by default, so a rename that lands while the pool holds a lock fails at once withError: stepping, database is locked (5)and the job exits 5.The same flake failed:
mainon 2026-10-02 (run beforefeat/broadcaster-chain-tip)Fix:
-cmd ".timeout 10000"on all fourALTER TABLErenames intests/test_pplns_coinbase_regtest.sh. Test-only; no pool code changes.Checked locally: while another connection holds
BEGIN EXCLUSIVEfor 2 s, the plain CLI rename exits 5 with "database is locked" and the.timeoutversion waits and succeeds.