Skip to content

release: attach artifacts when the release already exists - #101

Open
rsantacroce wants to merge 1 commit into
mainfrom
fix/release-attach-to-existing
Open

rsantacroce wants to merge 1 commit into
mainfrom
fix/release-attach-to-existing

Conversation

@rsantacroce

Copy link
Copy Markdown
Collaborator

Publishing v0.4.0 from the GitHub UI pushed the tag, and that push started release.yaml. Both tarballs built fine, but publish then ran gh release create, which failed with a release with the same tag name already exists. The release went out with no binaries (run).

Change: if the release already exists, gh release upload --clobber attaches the tarballs and SHA256SUMS to it and leaves the maintainer's title and notes alone. Otherwise it creates the release as before, so the git push origin vX.Y.Z path is unchanged.

v0.4.0 is already fixed by hand. The two tarballs that run built (commit 5f9ac48, the tag's commit, per each tarball's RELEASE file) were uploaded with a SHA256SUMS built from the run's own .sha256 files. A public download verifies with sha256sum -c.

Publishing v0.4.0 from the web UI pushed the tag, the tag push started
this workflow, and 'gh release create' then failed with 'a release with
the same tag name already exists' after both tarballs had built. The
release went out with no binaries. If the release exists, upload the
tarballs and SHA256SUMS to it and leave its notes alone.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant