fix: P2P: block merkle roots not validated before inserting into archive DB#104
Open
giaki3003 wants to merge 1 commit into
Conversation
…ive DB Bug: s2-r22 (primary) Finding: https://giaki3003.tech/#/findings/20260603-2200-thunder-peer-body-poison-archive-and-net-task-halt Severity: Medium Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
giaki3003
force-pushed
the
fix/s2-r22-p2p-block-merkle-roots-not-validated-before-inse
branch
from
cd758cc to
aaa4da2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discard peer bodies that fail connect-time validation (new
Archive::delete_body, called fromreorg_to_tipon connect failure) and log+drop the peer instead of propagating the reorg error out ofNetTask::run.The bug
P2P: block merkle roots not validated before inserting into archive DB
Severity: Medium. Full technical write-up (access-controlled): https://giaki3003.tech/#/findings/20260603-2200-thunder-peer-body-poison-archive-and-net-task-halt
Notes
First of a short series of fixes for this repo from a security review; the remaining fixes stack on this branch and will follow as separate PRs. Happy to adjust scope or split further on request.