feat(components): give the 23 unsized components a size source - #133
Merged
Conversation
Ten components measured their own content and nineteen carried a declared size. The remaining twenty-three had neither: inside a card's flex column they took width from align-items: stretch and kept height zero, so they painted nothing at all. Verified by rendering — all twenty-three produced zero pixels. The list is what makes it matter. chart, gauge, stat, icon, image, shape, sparkline, mockup, stepper, tag_cloud, callout, tooltip and the rest are precisely what a panel contains, and this project's target style puts nearly every graphic in a panel. Each default is derived rather than chosen: from the component's own painter formula where it has one (heatmap's cell grid, pill_nav's tab layout, tag_cloud's weighted flow, gauge's ring radius), from a documented rule where the project already states a size (sparkline 120x40, stat 280x180, skeleton 400x200), and from real usage in this repo's own examples otherwise. Text-bearing components measure their content, so a callout grows with its text. Also fixes three stats in a flex row rendering nothing, which was the same defect reached through auto width. Six of the seven tracked examples render byte-identically. mega-showcase changes because it is the only one containing unsized instances of these components — they were invisible and are now drawn. Closes #126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126. Part of the chantier #123.
Independent of the other six workstreams: disjoint file set, compiles and tests green on its own against
main. Mergeable in any order.Full rationale, measurements and evidence are in the commit message and in #126.