fix(components): keep painters inside the box the layout assigned - #134
Merged
Conversation
Several painters drew well outside the box they were given, which in a panel-based style means drawing on top of the next sibling or outside the card entirely. Measured against a 560x300 card with 24px padding: stat painted 120px tall in a 48px box, timeline started 33px left of its box and 9px outside the card, caption placed its box above the card top, switch, slider and countdown each ran past their own edges. Each now either draws within its box or reports the size it genuinely needs. stat shrinks to fit any assigned height rather than assuming one — the 48px it was measured against turned out to be a height the audit set deliberately, not a natural default, so pinning the fix to that number would have been wrong. badge and kbd stretched to the full card width because they have intrinsic measures but auto CSS width, so align-items: stretch won: a keycap rendered as a full-width slab. Both now keep their natural width inside a card. divider was investigated and left alone. Its reported 8px overhang traces to an explicit length that exceeded a smaller test card, which is correct behaviour. Closes #127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127. Part of the chantier #123.
Independent of the other six workstreams: disjoint file set, compiles and tests green on its own against
main. Mergeable in any order.Full rationale, measurements and evidence are in the commit message and in #127.