fix(validate): check content against its card, and report the real duration - #135
Merged
Conversation
…ration The geometry validator was blind in exactly the places a panel-based style stresses it. Content overflow was checked for text only; everything else fell through. A codeblock painting 578px inside a 300px card validated clean, as did a table 250px over and a list 223px over. The check now covers gradient_text, caption, rich_text and table through their existing intrinsics. codeblock and terminal stay out of that particular check because auto_scroll makes a smaller box deliberate — the new card-relative check covers them regardless. Nothing compared a component to the card containing it: one check compared to the frame, the other to the component's own box, and neither to the panel. Text with no height in a 300px card spilled 212px onto the background and validated clean. A new ContentOverflowsCard closes that, suppressed by a clipping ancestor but deliberately not by bleed — a component may leave the frame on purpose and still be responsible for its own contents. Rotation and skew were dropped when folding transforms, so the validator was blind to tilted panels, which are the grammar of this style. Transform folding now maps the box corners through the chain and takes the AABB. The announced duration was 22% wrong because it summed scene durations while the renderer subtracts transition overlap. It is now computed from build_frame_tasks — the same function render drives — and matches ffprobe exactly on the shipped template. Closes #128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128. Part of the chantier #123.
Independent of the other six workstreams: disjoint file set, compiles and tests green on its own against
main. Mergeable in any order.Full rationale, measurements and evidence are in the commit message and in #128.