sec(iac/aws): drop hardcoded branch ref from cleanup-staging.yml#565
sec(iac/aws): drop hardcoded branch ref from cleanup-staging.yml#565cristim wants to merge 1 commit into
Conversation
#386) Remove the `ref: feat/multicloud-web-frontend` override from all four actions/checkout steps in cleanup-staging.yml. Without the override, each checkout uses the ref selected at workflow_dispatch time (the branch or tag the operator chooses when triggering the workflow), which is the correct behaviour for a destroy workflow: it runs against whatever ref the operator has chosen and approved, not a hard-wired development branch that may not exist after the feature branch is merged. This closes the supply-chain risk where any commit pushed to the feature branch would automatically become the Terraform configuration used by the destroy workflow.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe cleanup-staging workflow removes hardcoded branch references from checkout steps across all cloud provider destroy jobs, enabling the workflow to use default ref resolution behavior instead of a specific feature branch. ChangesCleanup Workflow Security Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Summary
ref: feat/multicloud-web-frontendfrom all fouractions/checkoutsteps in.github/workflows/cleanup-staging.ymlworkflow_dispatchtime (the branch/tag the operator chooses), closing the supply-chain risk where commits to the feature branch automatically became the Terraform config used by the destroy workflowref:key remains in cleanup-staging.ymlCloses #386
Summary by CodeRabbit