fix(azure,gcp): fabricated commitment prices (hardcoded discount %) surfaced as real quotes

[cristim]

Problem. When the pricing API returns no reservation/commitment line, the code invents one from a hardcoded multiplier and surfaces it as a real OfferingDetails.TotalCost/SavingsPercentage:

• Azure: reservationPrice = onDemandPrice * hoursInTerm * 0.62 (services/compute/client.go:620-624; parallel reservationPrice == 0 branches in cache:512, cosmosdb:504, database:513, search:448).
• GCP: onDemand * hours * <0.63/0.45/0.85/...> (computeengine:760-766, cloudsql:446-452, memorystore:385-391, cloudstorage:439-445).

managedredis already does the right thing (returns an error when reservation pricing is missing).

Evidence. Azure 09-H4; GCP 10-M4. Violates feedback_nullable_not_zero / §5.

Impact. Misleading savings figures can justify uneconomical real purchases.

Suggested fix. Return an error (as managedredis does) or mark OfferingDetails.Estimated bool and omit SavingsPercentage when estimated, so the UI/CLI discloses it. Pairs with the savings-formula consolidation (I-20, report-12 D5).

References. Source: reports 09 (H4) + 10 (M4). Related: I-20 (shared SavingsPct with zero guard).

---

Filed from automated adversarial code review (see docs/code-review/). Source finding(s): 09-H4, 10-M4.

[cristim]

Both halves of this issue are now implemented across two PRs (split by provider since the files are disjoint):

• Azure side (compute/cache/cosmosdb/database/search): sec(azure): harden HTTP clients + fix fabricated reservation prices in managedredis/savingsplans and 5 pricing clients #1045
• GCP side (computeengine/cloudsql/memorystore/cloudstorage): fix(gcp): wire Count/pricing into GCP converters; refuse fabricated prices #1047

This issue should be closed once both PRs merge. Tracking here since neither PR uses an auto-closing Closes #1020 keyword on its own.

[cristim]

All target files already apply the correct fix on feat/multicloud-web-frontend:

• azure/services/cache, cosmosdb, database, search, compute, managedredis: return fmt.Errorf("no reservation pricing found for ...") when reservationPrice == 0, with a comment citing "issue fix(azure,gcp): fabricated commitment prices (hardcoded discount %) surfaced as real quotes #1020 H4".
• gcp/services/computeengine, cloudsql, memorystore, cloudstorage: return fmt.Errorf("no commitment pricing found for ...") when commitmentPrice == 0, citing issue fix(azure,gcp): fabricated commitment prices (hardcoded discount %) surfaced as real quotes #1020.

The hardcoded multipliers (* 0.62, * 0.63, etc.) are gone. Closing as completed.

---

Generated by Claude Code