Skip to content

chore(analytics): finish-or-remove decision for dead analytics collector/Query* surface (no-delete: needs human call) #1033

Description

@cristim

Problem. Per report 06 A1/L1/L2: NewCollector, SaveSnapshot/BulkInsertSnapshots, all Query*, and partition management have zero production callers; only RefreshMaterializedViews is wired, refreshing views over a table nothing writes to. Partitions stop being created after the seeded 3 months (M3); retention never runs. ~300 LOC + 4 mock files + an indexed FK column maintained for an unused API.

Evidence. Report 06 (A1, L1, L2, M3). Repo-wide grep confirms no live caller.

Suggested fix (explicit decision required, no-delete rule). Either (a) finish: wire the collector to an EventBridge schedule + monthly partition-maintenance job + expose Query* via the dashboard (then I-12's guards become mandatory), or (b) remove the unused surface. Do not leave the half-built scaffold.

References. Source: report 06 (A1, L1, L2, M3). Gated by I-12 (guards before wiring).


Filed from automated adversarial code review (see docs/code-review/). Source finding(s): 06-A1, 06-L1, 06-L2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    effort/mDaysimpact/internalTeam-internal onlypr-createdA PR has been opened for this issue (dedup guard for the auto-PR loop)pr-mergedThe PR for this issue has been mergedpriority/p3Polish / idea / may never shipseverity/highSignificant harmtriagedItem has been triagedtype/choreMaintenance / non-user-visibleurgency/this-quarterWithin the quarter

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions