Skip to content

Disable plan: scheduled purchase removed but plan toggle stays ON (Planned 6.4) #774

Description

@cristim

Symptom (Planned Purchases 6.4)

Clicking "Disable plan" next to a scheduled purchase removes the scheduled purchase from the list, BUT the plan's toggle on the Plans page remains ON. State is inconsistent: the plan is still enabled, yet its scheduled purchase is gone.

Two parts

  1. Bug: the state mutations are not atomic. Either:
    • Disabling a plan from the scheduled-purchase row should also flip the plan toggle off, OR
    • It should leave both alone but instead "pause" the scheduled purchase (see Planned Purchases 6.1 for the pause flow).
  2. Design question (note in this issue): the QA suggestion is "leaving users the option to enable the plan and the scheduled purchase at a later time". That's a pause-not-delete semantics for the scheduled purchase. The "Disable plan" label may itself be misleading -- consider renaming.

Acceptance (V1 -- fix the state inconsistency only)

  • Clicking "Disable plan" from a scheduled-purchase row makes the plan toggle OFF on the Plans page (atomically with the scheduled purchase being removed).
  • A regression test exercises the cross-page state: after Disable plan, fetch the plan and assert enabled = false.
  • Comment in this issue with the design question about pause vs delete semantics; do NOT change the label or semantics without product input.

Source

Planned Purchases 6.4, exploratory testing 2026-05-27.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions