Skip to content

fix(cli): recover() in multi_service_engine_versions worker goroutine #997

Description

@cristim

Summary

cmd/multi_service_engine_versions.go:112 runs a wg.Wait()-joined goroutine that calls queryRDSInstancesInRegion (map writes + AWS SDK calls, both can panic) with no recover(). A panic there crashes the CLI process. This is the CLI batch path, out of scope for #672 (which covered the 3 Lambda fire-and-forget goroutines, fixed in PR #859), but it is the same class of defect.

Acceptance criteria

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    effort/xsTrivial / one-linerimpact/internalTeam-internal onlypr-createdA PR has been opened for this issue (dedup guard for the auto-PR loop)priority/p3Polish / idea / may never shipseverity/lowMinor harmtriagedItem has been triagedtype/bugDefecturgency/eventuallyNo deadline

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions