Repository navigation
chore(ci): gofmt base-drifted Go files to unblock pre-commit - #1097
Conversation
The base branch shipped five gofmt-dirty Go files, causing the go-fmt hook (run via pre-commit --all-files) to fail on every open PR regardless of what that PR changed. Changes are purely whitespace/alignment: comment-column alignment and struct-literal field alignment. No token changes. Closes #1096
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR reformats five Go source files to comply with ChangesGofmt Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Root cause
The base branch
feat/multicloud-web-frontendships five Go files that failgofmt, causing thego-fmtpre-commit hook to fail on every open PR when CI runspre-commit run --all-files(which checks the whole tree, not just the PR diff).What this PR does
Runs
gofmt -won all five affected files. The diff is purely whitespace/alignment (comment-column alignment, struct-literal field alignment, one stray blank line). No token changes; confirmed withgit diffhunk-by-hunk review.Files changed
internal/auth/service_password.go-- comment-column alignmentinternal/database/open_from_env_test.go-- struct-literal field alignmentinternal/credentials/cipher_extra_test.go-- stray blank lineproviders/azure/services/compute/client_test.go-- struct-literal field alignmentinternal/execution/fanout_test.go-- comment-column alignmentVerification
gofmt -l .returns empty after the change (all files clean)go build ./...passes with no errorsCloses #1096
Unblocks #1090, #1091, and every other open PR that fails the
--all-filesgo-fmt hook.Summary by CodeRabbit