Skip to content

chore(ci): gofmt base-drifted Go files to unblock pre-commit - #1097

Merged
cristim merged 1 commit into
feat/multicloud-web-frontendfrom
chore/gofmt-base-drift
Jun 7, 2026
Merged

cristim merged 1 commit into
feat/multicloud-web-frontendfrom
chore/gofmt-base-drift

Conversation

@cristim

@cristim cristim commented Jun 7, 2026 •

Copy link
Copy Markdown
Member

Root cause

The base branch feat/multicloud-web-frontend ships five Go files that fail gofmt, causing the go-fmt pre-commit hook to fail on every open PR when CI runs pre-commit run --all-files (which checks the whole tree, not just the PR diff).

What this PR does

Runs gofmt -w on all five affected files. The diff is purely whitespace/alignment (comment-column alignment, struct-literal field alignment, one stray blank line). No token changes; confirmed with git diff hunk-by-hunk review.

Files changed

  • internal/auth/service_password.go -- comment-column alignment
  • internal/database/open_from_env_test.go -- struct-literal field alignment
  • internal/credentials/cipher_extra_test.go -- stray blank line
  • providers/azure/services/compute/client_test.go -- struct-literal field alignment
  • internal/execution/fanout_test.go -- comment-column alignment

Verification

  • gofmt -l . returns empty after the change (all files clean)
  • go build ./... passes with no errors

Closes #1096

Unblocks #1090, #1091, and every other open PR that fails the --all-files go-fmt hook.

Summary by CodeRabbit

  • Chores
    • Internal code formatting and whitespace alignment updates across test and utility files with no impact to user-facing functionality.

The base branch shipped five gofmt-dirty Go files, causing the go-fmt hook
(run via pre-commit --all-files) to fail on every open PR regardless of what
that PR changed.

Changes are purely whitespace/alignment: comment-column alignment and
struct-literal field alignment. No token changes.

Closes #1096
@cristim cristim added triaged Item has been triaged priority/p2 Backlog-worthy severity/low Minor harm urgency/this-sprint Within the current sprint impact/internal Team-internal only effort/xs Trivial / one-liner type/chore Maintenance / non-user-visible labels Jun 7, 2026
@coderabbitai

coderabbitai Bot commented Jun 7, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 410cd66d-c0e8-499a-a94d-e2ce2440f549

📥 Commits

Reviewing files that changed from the base of the PR and between 2276bce and ea34441.

📒 Files selected for processing (5)
  • internal/auth/service_password.go
  • internal/credentials/cipher_extra_test.go
  • internal/database/open_from_env_test.go
  • internal/execution/fanout_test.go
  • providers/azure/services/compute/client_test.go
💤 Files with no reviewable changes (1)
  • internal/credentials/cipher_extra_test.go

📝 Walkthrough

Walkthrough

This PR reformats five Go source files to comply with gofmt standards. The changes are purely whitespace and alignment adjustments to password constants, test fixtures, and helper functions with no functional logic changes.

Changes

Gofmt Cleanup

Layer / File(s) Summary
Format code across multiple files
internal/auth/service_password.go, internal/credentials/cipher_extra_test.go, internal/database/open_from_env_test.go, internal/execution/fanout_test.go, providers/azure/services/compute/client_test.go
Adjust whitespace and alignment in password validation constants (minPasswordLength, maxPasswordLength, passwordHistorySize) and redactEmail string-split logic; remove stray line-number literals from TestDecrypt_BadBase64Ciphertext; reformat env map initialization and AzureRetailPriceItem struct literal field alignment in test fixtures; adjust comment-column alignment on channel receive operations. No semantic changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

priority/p3, urgency/this-quarter

Poem

A rabbit hops through, straightens each line,
Whitespace aligned, indentation so fine,
gofmt now smiles, the CI will pass,
Five files now gleaming with perfectly spaced class! ✨
No logic was bent, just brackets arranged,
The base branch at last will not be estranged. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(ci): gofmt base-drifted Go files to unblock pre-commit' accurately summarizes the main change: running gofmt on formatting-drift Go files to fix CI pre-commit checks.
Linked Issues check ✅ Passed The PR addresses all objectives from #1096: identifies and fixes five gofmt-dirty files with pure whitespace changes, restores clean gofmt state, and unblocks PRs failing the go-fmt hook.
Out of Scope Changes check ✅ Passed All changes are scoped to formatting corrections of the five specified files from #1096; no unrelated code modifications or functionality changes are present.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/gofmt-base-drift

Comment @coderabbitai help to get the list of available commands and usage tips.

@cristim

cristim commented Jun 7, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim
cristim merged commit f5632b3 into feat/multicloud-web-frontend Jun 7, 2026
3 of 4 checks passed
@cristim
cristim deleted the chore/gofmt-base-drift branch July 27, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p2 Backlog-worthy severity/low Minor harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant