Skip to content

fix(test): pin 000086 migration test to version 86, not HEAD #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 1 commit into from
Jul 17, 2026
Merged

fix(test): pin 000086 migration test to version 86, not HEAD #1436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions internal/database/postgres/migrations/000086_remove_approve_own_from_standard_users_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,11 @@ func TestMigration_RemoveApproveOwnFromStandardUsers(t *testing.T) {
require.True(t, standardUsersHasPurchaseVerb(t, ctx, pool, "retry-own"),
"precondition: Standard Users must hold retry-own:purchases at v83")

// Apply the remaining chain, which includes 000086.
require.NoError(t, migrations.RunMigrations(ctx, pool, migrationsPath, "", ""))
// Pin at exactly 000086 (the migration under test). Using RunMigrations
// (migrate to HEAD) would also run any migrations added on later branches
// (e.g. 000087, 000088) whose permission side-effects could mask a regression
// in 000086 or cause spurious failures here if they alter the same group.
require.NoError(t, migrations.MigrateToVersion(ctx, pool, migrationsPath, 86))

// Four-eyes (issue #1407): approve-own must be gone.
assert.False(t, standardUsersHasPurchaseVerb(t, ctx, pool, "approve-own"),
Expand All @@ -79,10 +82,14 @@ func TestMigration_RemoveApproveOwnFromStandardUsers(t *testing.T) {
defer container.Cleanup(ctx)
pool := container.DB.Pool()

// Full head has 000086 applied, so approve-own is removed.
require.NoError(t, migrations.RunMigrations(ctx, pool, migrationsPath, "", ""))
// Pin at exactly 000086 before rolling back. RunMigrations would migrate
// to HEAD (which varies by branch), so RollbackMigrations(1) would roll
// back whatever the LATEST migration is (000087, 000088, ...) rather than
// 000086.down -- leaving approve-own absent and causing a spurious failure.
// Pinning to 86 guarantees RollbackMigrations(1) always exercises 000086.down.
require.NoError(t, migrations.MigrateToVersion(ctx, pool, migrationsPath, 86))
require.False(t, standardUsersHasPurchaseVerb(t, ctx, pool, "approve-own"),
"head state: approve-own must be absent after 000086")
"post-086 state: approve-own must be absent at version 86")

// Roll back one step (000086.down) and confirm approve-own is restored.
require.NoError(t, migrations.RollbackMigrations(ctx, pool, migrationsPath, 1))
Expand Down
Loading