Skip to content

fix(cmd): use portable os.Stdin.Fd for password read on Windows (follow-up to #1279) #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristim merged 2 commits into from
Jul 20, 2026
Merged

fix(cmd): use portable os.Stdin.Fd for password read on Windows (follow-up to #1279) #1459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f919c
fix(cmd): use portable os.Stdin.Fd for password read on Windows (foll…
cristim Jul 19, 2026
6d74785
fix(cmd): justify terminal descriptor conversion
cristim Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/configure_azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (
"os/exec"
"regexp"
"strings"
"syscall"

"time"

Expand Down Expand Up @@ -273,7 +272,10 @@ func promptForAzureCredentialFields(reader *bufio.Reader, creds *AzureCredential

if creds.ClientSecret == "" {
fmt.Print("Client Secret (password): ")
secret, err := term.ReadPassword(syscall.Stdin)
// int(os.Stdin.Fd()) is portable: syscall.Stdin is an int on Unix but a
// Handle on Windows, so passing it to term.ReadPassword (which takes an
// int) breaks GOOS=windows builds.
secret, err := term.ReadPassword(int(os.Stdin.Fd())) // #nosec G115 -- OS file descriptors fit in int on every supported platform
if err != nil {
return fmt.Errorf("failed to read secret: %w", err)
}
Expand Down
Loading